OpenSeaMap Forum

For new registrations: Please create and activate an account. Afterwards send an email to forum.openseamap@gmail.com including a short message and your username to get write access to this forum. Thanks!
Für neue Registrierungen: Bitte erstelle einen neuen Account und schalte ihn frei. Anschließend sende eine kurze Mail mit deinem Nutzernamen an forum.openseamap@gmail.com um Schreibzugriff für dieses Forum zu bekommen. Danke!

You are not logged in.

#1 2019-07-24 22:58:02

zstadler
Member
Registered: 2017-06-07
Posts: 6

Bulk update: fix inconsistent formats of seamark:light:sequence tags

The IHO standard for S-57 says the format for SIGSEQ is "00.8+(02.2)+00.8+(05.2)" or "(00.8)+02.2+(00.8)+05.2" where the intervals of eclipse are using parenthesis and the intervals of light do not.

It seems like a significant portion of the seamark:light:sequence tags do not use this syntax.

Following to the Automated Edits code of conduct, I would like to discuss fixing the following non-conforming formats:

  • 2153 objects do not use parenthesis for the eclipse periods. Many also use a comma for the decimal separator. E.g., "0,5+1,5+0,5+7,5".
    Most of them seem to be related to the Seamark import for Norway, although the import documentation says the "0.5+(0.5)+0.5+(0.5)+0.5+(0.5)+1.5+(1.5)" format will be used.

    The fix: commas should be replaced with a "." and even intervals in the series should be enclosed within parenthesis. E.g., "0.5+(1.5)+0.5+(7.5)"
    Note that there is no need for special handling of objects having "seamark:light:character"="Oc" since the first interval in their sequence is always the largest.

  • There are 38 objects that use a repeat count in addition to the above. E.g., "(0,3+0,7)*6+2+7". 

    The fix: they should be expanded. E.g., "0.3+(0.7)+0.3+(0.7)+0.3+(0.7)+0.3+(0.7)+0.3+(0.7)+0.3+(0.7)+2+(7)"

  • 1811 objects have the additional flashes separated by commas. E.g., "2+(2),2+(14)".
    Most of them seem to be related to the US NGA Pub. bulk imports.
    The fix:  commas should be replaced with a "+" sign. E.g., "2+(2)+2+(14)".

Please let me know if you have suggestions for improvements, questions, or comments.

Last edited by zstadler (2019-07-24 23:01:58)

Offline

#2 2019-07-29 19:27:55

zstadler
Member
Registered: 2017-06-07
Posts: 6

Re: Bulk update: fix inconsistent formats of seamark:light:sequence tags

I hope to complete the update by the end of the week.

Offline

#3 2019-07-29 21:29:41

zstadler
Member
Registered: 2017-06-07
Posts: 6

Re: Bulk update: fix inconsistent formats of seamark:light:sequence tags

Completed with the following changesets:

72784803 - additional flashes separated by commas
72785527 - add parenthesis for the eclipse periods and use a period as the decimal separator
72787429 - expand repeats and use a period as the decimal separator

Offline

Board footer

Powered by FluxBB